001///////////////////////////////////////////////////////////////////////////////////////////////
002// checkstyle: Checks Java source code and other text files for adherence to a set of rules.
003// Copyright (C) 2001-2026 the original author or authors.
004//
005// This library is free software; you can redistribute it and/or
006// modify it under the terms of the GNU Lesser General Public
007// License as published by the Free Software Foundation; either
008// version 2.1 of the License, or (at your option) any later version.
009//
010// This library is distributed in the hope that it will be useful,
011// but WITHOUT ANY WARRANTY; without even the implied warranty of
012// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
013// Lesser General Public License for more details.
014//
015// You should have received a copy of the GNU Lesser General Public
016// License along with this library; if not, write to the Free Software
017// Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
018///////////////////////////////////////////////////////////////////////////////////////////////
019
020package com.puppycrawl.tools.checkstyle.checks.coding;
021
022import java.util.HashMap;
023import java.util.Map;
024
025import com.puppycrawl.tools.checkstyle.StatelessCheck;
026import com.puppycrawl.tools.checkstyle.api.AbstractCheck;
027import com.puppycrawl.tools.checkstyle.api.DetailAST;
028import com.puppycrawl.tools.checkstyle.api.TokenTypes;
029import com.puppycrawl.tools.checkstyle.utils.TokenUtil;
030
031/**
032 * <div>
033 * Checks that overloaded methods are grouped together. Overloaded methods have the same
034 * name but different signatures where the signature can differ by the number of
035 * input parameters or type of input parameters or both.
036 * </div>
037 *
038 * @since 5.8
039 */
040@StatelessCheck
041public class OverloadMethodsDeclarationOrderCheck extends AbstractCheck {
042
043    /**
044     * A key is pointing to the warning message text in "messages.properties"
045     * file.
046     */
047    public static final String MSG_KEY = "overload.methods.declaration";
048
049    /**
050     * A key is pointing to the warning message text in "messages.properties"
051     * file.
052     */
053    public static final String MSG_ORDER = "overload.methods.declaration.order";
054
055    /**
056     * Control whether to order overloaded methods by increasing parameter count.
057     */
058    private boolean orderByIncreasingParameterCount;
059
060    /**
061     * Setter to control whether to enforce order by increasing parameter count (arity) or not.
062     *
063     * @param orderByIncreasingParameterCount true if order by increasing parameter
064     *               count is required.
065     * @since 13.7.0
066     */
067    public void setOrderByIncreasingParameterCount(boolean orderByIncreasingParameterCount) {
068        this.orderByIncreasingParameterCount = orderByIncreasingParameterCount;
069    }
070
071    @Override
072    public int[] getDefaultTokens() {
073        return getRequiredTokens();
074    }
075
076    @Override
077    public int[] getAcceptableTokens() {
078        return getRequiredTokens();
079    }
080
081    @Override
082    public int[] getRequiredTokens() {
083        return new int[] {
084            TokenTypes.OBJBLOCK,
085        };
086    }
087
088    @Override
089    public void visitToken(DetailAST ast) {
090        final int parentType = ast.getParent().getType();
091
092        final int[] tokenTypes = {
093            TokenTypes.CLASS_DEF,
094            TokenTypes.ENUM_DEF,
095            TokenTypes.INTERFACE_DEF,
096            TokenTypes.LITERAL_NEW,
097            TokenTypes.RECORD_DEF,
098        };
099
100        if (TokenUtil.isOfType(parentType, tokenTypes)) {
101            checkOverloadMethodsGrouping(ast);
102        }
103    }
104
105    /**
106     * Checks that if overload methods are grouped together they should not be
107     * separated from each other.
108     *
109     * @param objectBlock
110     *        is a class, interface or enum object block.
111     */
112    private void checkOverloadMethodsGrouping(DetailAST objectBlock) {
113        final int allowedDistance = 1;
114        DetailAST currentToken = objectBlock.getFirstChild();
115        final Map<String, Integer> methodIndexMap = new HashMap<>();
116        final Map<String, Integer> methodLineNumberMap = new HashMap<>();
117
118        final Map<String, Integer> methodParameterCountMap = new HashMap<>();
119        final Map<String, Boolean> methodIsOrderedMap = new HashMap<>();
120
121        int currentIndex = 0;
122        while (currentToken != null) {
123            if (currentToken.getType() == TokenTypes.METHOD_DEF) {
124                currentIndex++;
125                final String methodName =
126                        currentToken.findFirstToken(TokenTypes.IDENT).getText();
127                final Integer previousIndex = methodIndexMap.get(methodName);
128
129                if (previousIndex != null) {
130                    final DetailAST previousSibling = currentToken.getPreviousSibling();
131                    final boolean isMethod = previousSibling.getType() == TokenTypes.METHOD_DEF;
132
133                    if (!isMethod || currentIndex - previousIndex > allowedDistance) {
134                        final int previousLineWithOverloadMethod =
135                                methodLineNumberMap.get(methodName);
136                        log(currentToken, MSG_KEY,
137                                previousLineWithOverloadMethod);
138                    }
139
140                    if (orderByIncreasingParameterCount) {
141                        checkMethodOrdering(currentToken, methodName,
142                                methodIsOrderedMap, methodParameterCountMap);
143                    }
144                }
145                methodIsOrderedMap.putIfAbsent(methodName, Boolean.TRUE);
146                methodIndexMap.put(methodName, currentIndex);
147                methodLineNumberMap.put(methodName, currentToken.getLineNo());
148                methodParameterCountMap.put(methodName, getParameterCount(currentToken));
149            }
150            currentToken = currentToken.getNextSibling();
151        }
152    }
153
154    /**
155     * Checks that overloaded methods are ordered with increasing parameter count
156     * or not.
157     *
158     * @param currentMethod ast of the method.
159     * @param methodName method name.
160     * @param methodIsOrderedMap
161     *        is a map of method names to booleans indicating whether the method is ordered.
162     * @param methodParameterCountMap
163     *        is a map of method names to integers indicating the parameter count of the previous
164     *        similar method.
165     */
166    private void checkMethodOrdering(DetailAST currentMethod, String methodName,
167        Map<String, Boolean> methodIsOrderedMap, Map<String, Integer> methodParameterCountMap) {
168
169        final int currentParamCount = getParameterCount(currentMethod);
170        final boolean isOrdered = methodIsOrderedMap.get(methodName)
171                            && currentParamCount >= methodParameterCountMap.get(methodName);
172        if (!isOrdered) {
173            methodIsOrderedMap.put(methodName, Boolean.FALSE);
174            log(currentMethod, MSG_ORDER);
175        }
176    }
177
178    /**
179     * Get the parameter count of a method.
180     *
181     * @param method the method AST
182     * @return the parameter count of the method
183     */
184    private static int getParameterCount(DetailAST method) {
185        final DetailAST params = method.findFirstToken(TokenTypes.PARAMETERS);
186        return params.getChildCount(TokenTypes.PARAMETER_DEF);
187    }
188}